siloos-code-review

Guidelines and procedures for reviewing SiloOS frontend, hardware bridge, and protocol changes.

SKILL.md.agent/skills/siloos-code-review/SKILL.md

SiloOS Code Review Skill

When to Use

Before merging any changes
After completing a task (self-review)
When auditing code quality
Before deployment to Pi

Procedure

Step 1: Scope the Review

Identify which files changed and which domain they belong to:

dashboard/src/ → Frontend review
ble_bridge.py → Hardware bridge review
dashboard/src/sfwu/ → SFWU protocol review

Step 2: Verify Build & Types

cd dashboard && npm run build && npm run lint
npx tsc --noEmit

Step 3: Security & Compliance

No hardcoded secrets in config.json or code
WebSocket messages validated
Imports use correct paths (parsers/ not responses/)
Logger used instead of console.log

Step 4: Protocol Correctness

CRC32 calculation verified
Byte offsets correct in parsers
Command codes match constants.ts

Related in testing

frontend-testing-langgenius-dify

Generate Vitest + React Testing Library tests for Dify frontend components, hooks, and utilities. Triggers on testing, s...

skill-creator-langgenius-dify

Guide for creating effective skills. This skill should be used when users want to create a new skill (or update an exist...

browser-use-browser-use-browser-use

Automates browser interactions for web testing, form filling, screenshots, and data extraction. Use when the user needs...